Move CVXPY converters to DNLP repo, simplify to pure C bindings#26
Merged
Move CVXPY converters to DNLP repo, simplify to pure C bindings#26
Conversation
- Remove C_problem class and ATOM_CONVERTERS from this package - Now only re-exports low-level C functions from _core extension - Remove cvxpy/scipy from core dependencies (only numpy needed) - Add cvxpy/scipy to test dependencies for integration tests - Update tests to import C_problem from cvxpy.reductions.solvers.nlp_solvers.diff_engine - Update CLAUDE.md with improved documentation This makes dnlp-diff-engine a pure C autodiff library with no circular dependencies, ready for PyPI publishing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Lockfiles should not be committed for libraries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
@dance858 I made this PR and some corresponding changes to https://github.com/cvxgrp/DNLP/pull/131/changes in preparation for the migration. This is also something I had in mind.. the diff-engine should not need to take care of the conversion of expression trees, it should just provide derivatives. |
Collaborator
|
Awesome! I like this separation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes dnlp-diff-engine a pure C autodiff library with no circular dependencies, ready for PyPI publishing.